Skip to content

#CNV -62298 - CPU hotplug with networkInterfaceMultiqueue enabled #95585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

#CNV -62298 - CPU hotplug with networkInterfaceMultiqueue enabled #95585

merged 1 commit into from
Jul 15, 2025
+8 −0

Conversation

Vaishali-gif-rh
Copy link
Contributor

@Vaishali-gif-rh Vaishali-gif-rh commented Jul 3, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 3, 2025 •
edited
Loading

🤖 Tue Jul 15 10:39:48 - Prow CI generated the docs preview:

https://95585--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html
https://95585--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/managing_vms/virt-edit-vms.html
https://95585--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/managing_vms/virt-edit-vms.html

orelmisan
orelmisan approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Vaishali-gif-rh!

@Vaishali-gif-rh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 8, 2025
@orelmisan
Copy link
Member

Thank you for the changes @Vaishali-gif-rh!
Please consider adjusting the commit message to reflect the change.

@Vaishali-gif-rh
Copy link
Contributor Author

@orelmisan - done

@eromanova97
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 8, 2025
eromanova97
eromanova97 reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor

@eromanova97 eromanova97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few small suggestions, thank you!

/remove-label peer-review-in-progress

/label peer-review-done

Edit: Also please add the link to previw to the first comment: https://95585--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html#virt-hot-plugging-cpu_virt-edit-vms
Thanks!

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 8, 2025
@Vaishali-gif-rh
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 11, 2025
@dfitzmau dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 11, 2025
dfitzmau
dfitzmau reviewed Jul 11, 2025
View reviewed changes
@dfitzmau
Copy link
Contributor

Hi @Vaishali-gif-rh . Nice work. I added some minor clarifications for "hot plug". Would you be OK to take a look?

@Vaishali-gif-rh
Copy link
Contributor Author

@dfitzmau -Thanks for all the suggestions! I’ve incorporated the feedback and pushed the updated content. Let me know if everything looks good to proceed with the merge.

dfitzmau
dfitzmau reviewed Jul 14, 2025
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 15, 2025

@Vaishali-gif-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit ee18491 into openshift:main Jul 15, 2025
2 checks passed
@dfitzmau
Copy link
Contributor

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #96101

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 15, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: #95585 failed to apply on top of branch "enterprise-4.18":

Applying: removed extra bullet
.git/rebase-apply/patch:17: trailing whitespace.
* Existing network interfaces that you attach before the CPU hot plug retain their original queue count, even after you add more virtual CPUs (vCPUs). The underlying virtualization technology causes this expected behavior.  
.git/rebase-apply/patch:18: trailing whitespace.
* To update the queue count of existing interfaces to match the new vCPU configuration, you can restart the VM. A restart is only necessary if the update improves performance.  
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	modules/virt-hot-plugging-cpu.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-hot-plugging-cpu.adoc
CONFLICT (content): Merge conflict in modules/virt-hot-plugging-cpu.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 removed extra bullet

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dfitzmau
Copy link
Contributor

Hi @Vaishali-gif-rh . A merge conflict exists on the 4.18 branch. Would you be OK to create a manual PR and fix the issue?

@Vaishali-gif-rh
Copy link
Contributor Author

Sure @dfitzmau - I'll create another PR for 4.18.

@Vaishali-gif-rh Vaishali-gif-rh mentioned this pull request Jul 16, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfitzmau dfitzmau dfitzmau left review comments

@eromanova97 eromanova97 eromanova97 left review comments

@orelmisan orelmisan orelmisan approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Vaishali-gif-rh @ocpdocs-previewbot @orelmisan @eromanova97 @dfitzmau @openshift-cherrypick-robot